Skip to content

ci: Disable staticcheck on tip-of-tree compiler. #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aalexand merged 2 commits into from
Nov 2, 2021
Merged

ci: Disable staticcheck on tip-of-tree compiler. #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
101081c
ci: Disable staticcheck on tip-of-tree compiler.
s-kanev Nov 2, 2021
86d63d3
Set RUN_STATICCHCECK for subsequent steps.
s-kanev Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ jobs:
cd $HOME/gotip/src
./make.bash
echo "GOROOT=$HOME/gotip" >> $GITHUB_ENV
echo "RUN_STATICCHECK=false" >> $GITHUB_ENV
echo "$HOME/gotip/bin:$PATH" >> $GITHUB_PATH

- name: Checkout the repo
Expand Down Expand Up @@ -122,6 +123,7 @@ jobs:
cd $HOME/gotip/src
./make.bash
echo "GOROOT=$HOME/gotip" >> $GITHUB_ENV
echo "RUN_STATICCHECK=false" >> $GITHUB_ENV
echo "$HOME/gotip/bin" >> $GITHUB_PATH

- name: Checkout the repo
Expand Down
4 changes: 3 additions & 1 deletion test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ echo "mode: $MODE" > coverage.txt
# All packages.
PKG=$(go list ./...)

staticcheck $PKG
if [ "$RUN_STATICCHECK" != "false" ]; then
staticcheck $PKG
fi

# Packages that have any tests.
PKG=$(go list -f '{{if .TestGoFiles}} {{.ImportPath}} {{end}}' ./...)
Expand Down