Use a pthreadpool_atomic_size_t instead of an fxdiv_divisor_size_t for threads_count as the former can be loaded and stored atomically.#80
Merged
copybara-service[bot] merged 1 commit intomainfrom Oct 20, 2025
Conversation
copybara-service
bot
force-pushed
the
test_821114197
branch
4 times, most recently
from
1d61735 to
aa4010b
Compare
…` for `threads_count` as the former can be loaded and stored atomically. This avoids confusing the thread sanitizer in some situations. This change also tidies up the logic around when/how to schedule worker threads. PiperOrigin-RevId: 821572382
copybara-service
bot
force-pushed
the
test_821114197
branch
from
aa4010b to
8017cbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a
pthreadpool_atomic_size_tinstead of anfxdiv_divisor_size_tforthreads_countas the former can be loaded and stored atomically.This avoids confusing the thread sanitizer in some situations.
This change also tidies up the logic around when/how to schedule worker threads.