Add tests for server #20
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
brianquinlan
left a comment
brianquinlan
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Please add the issue number to the pull description.
| @@ -0,0 +1,13 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Could you add a license to the top of this file? You can use any other file in the project as an example but make sure that you change the year to 2020.
There was a problem hiding this comment.
Also, every file needs a comment explaining what it is doing.
server-example/test_app.py
Outdated
| def test_image(client): | ||
| rv = client.get("/") | ||
| assert b'build' in rv.data | ||
| assert b'passing' in rv.data No newline at end of file |
There was a problem hiding this comment.
Add a newline at the end here.
brianquinlan
left a comment
brianquinlan
left a comment
There was a problem hiding this comment.
Thank you so much for the change!
|
|
||
|
|
||
| @nox.session(python=['3.4', '3.5', '3.6', '3.7']) | ||
| @nox.session(python=['3.4', '3.5', '3.6', '3.7', '3.8']) |
There was a problem hiding this comment.
That should probably be in another PR but it's fine this time.
| session.install('flake8') | ||
| session.run('flake8', | ||
| 'pypadges,tests') | ||
| session.run('flake8', 'pybadges') |
There was a problem hiding this comment.
That should probably be in another PR but it's fine this time.
3 participants
No description provided.