Skip to content

fix: Refine Pyink blank line insertion logic and fix range-based formatting regressions. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 13, 2026
Merged

fix: Refine Pyink blank line insertion logic and fix range-based formatting regressions. #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions patches/pyink.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,11 +724,10 @@
+ and not self.previous_line.depth
+ and not current_line.depth
and not current_line.is_import
+ and not current_line.is_comment
and not current_line.is_fmt_pass_converted(first_leaf_matches=is_import)
+ and not current_line.is_fmt_pass_converted()
):
- return 1, 0
+ return (before or 1), 0
return 1, 0

if (
- self.previous_line.is_import
Expand Down
4 changes: 2 additions & 2 deletions src/pyink/lines.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,10 +708,10 @@ def _maybe_empty_lines(self, current_line: Line) -> tuple[int, int]:
and not self.previous_line.depth
and not current_line.depth
and not current_line.is_import
and not current_line.is_comment
and not current_line.is_fmt_pass_converted(first_leaf_matches=is_import)
and not current_line.is_fmt_pass_converted()
):
return (before or 1), 0
return 1, 0

if (
(
Expand Down
Loading