Merged
Conversation
Collaborator
|
Thanks for fixing the typos. Let's not add codespell at this time, but I'd be happy to merge the PR w/ just the typo fixes. |
yarikoptic
force-pushed
the
enh-codespell
branch
from
ef15718 to
86b3cf9
Compare
Contributor
Author
|
You are the boss. I force pushed kicking away the last commit with the workflow. Let me know if you would like to get rid of |
Collaborator
Yep, thanks |
=== Do not change lines below ===
{
"chain": [],
"cmd": "git-sedi thats 'that is'",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
86b3cf9 to
5afa444
Compare
Contributor
Author
|
IMHO "your loss", but done now. |
Collaborator
|
Thanks Yari! I'm not opposed to adding spell check more generally; just adding codespell would require more research and review on my part and would delay getting things checked in. So, I'm happy to merge the pure-fix PR now rather than having an easy fix get blocked by a slower process. |
dbieber
changed the title
Contributor
Author
|
Understood. Let me know if your want sister pr with those |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.