Simple implementation of allowing externally defined formatters#75
Closed
monkut wants to merge 7 commits intogoogle:masterfrom
Closed
Simple implementation of allowing externally defined formatters#75monkut wants to merge 7 commits intogoogle:masterfrom
monkut wants to merge 7 commits intogoogle:masterfrom
Conversation
Collaborator
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
added 5 commits
June 17, 2017 00:22
…ng run is '__main__.py' (uses filepath of __main__.py to determine the package name)
…sary field output.
Collaborator
|
FYI objects that defines a custom __str__ method are now serialized using that custom __str__ method. |
Collaborator
|
Thanks for the PR. Closing as this is now obsolete. We eventually added this functionality (years after your original PR) in #345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there is a TODO in
_PrintResultto provide better handling of output formatting, but this is a quick an easy way to allow end-users to provide their own defined formatters.For your consideration.
In response to raised issue #74