Add optional space prop for JSON.stringify#15
Merged
Eyas merged 3 commits intogoogle:masterfrom Apr 6, 2020
Merged
Conversation
Eyas
requested changes
Apr 6, 2020
| */ | ||
| export class JsonLd<T extends Thing> extends React.Component<{ | ||
| item: WithContext<T>; | ||
| space?: string | number; |
Collaborator
There was a problem hiding this comment.
Can you as a jsdoc above this line?
Contributor
Author
There was a problem hiding this comment.
Just pushed a commit, is that what you had in mind or?
Collaborator
There was a problem hiding this comment.
My bad for not elaborating: you can put inline JSDocs above a type declaration (i.e. right above "space:") describing it, and it shows up in IDEs etc when someone's looking at props or seeing the autocomplete for space
Contributor
Author
There was a problem hiding this comment.
string | number is used as type declaration here instead of JSDoc, no? I don't think we can write JSDoc in inline interface declaration like in this case. IDE is complaining and TS won't compile. Can you check?
Eyas
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14