Skip to content

change build target to es5#17

Merged
Eyas merged 1 commit intogoogle:masterfrom
bfellows37:patch-1
May 8, 2020
Merged

change build target to es5#17
Eyas merged 1 commit intogoogle:masterfrom
bfellows37:patch-1

Conversation

@bfellows37
Copy link
Contributor

This package has trouble with Internet Explorer 11. The reason is that it uses 'class' syntax and TS will retain that syntax when compiling to ES2015. Compiled to ES5, it works with IE11.

I propose changing the build target to extend support to IE11.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bfellows37
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@Eyas Eyas merged commit 7f79d29 into google:master May 8, 2020
@Eyas
Copy link
Collaborator

Eyas commented May 8, 2020

Thank you for this!

@bfellows37
Copy link
Contributor Author

@Eyas out of curiosity, what does your npm publish schedule look like? I notice there have been 3 PRs merged since it was last published.

Eyas added a commit to Eyas/react-schemaorg that referenced this pull request May 11, 2020
w/ fixes for es5 (see google#17) targetting.
@Eyas
Copy link
Collaborator

Eyas commented May 11, 2020

@bfellows37 There's no set schedule, but I just published 1.0.2

@bfellows37
Copy link
Contributor Author

I appreciate it, @Eyas makes my life a little simpler :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants