Support using <script> tags directly.#24
Merged
Eyas merged 2 commits intogoogle:masterfrom Jul 20, 2020
Merged
Conversation
Fixes google#23. Some tools such as `next/head` rely on a script tag existing directly under the `<Head>` component. Allowing a react-schemaorg user just pass the props opaquely to a `<script>` tag gives us both encapsulation while getting the library to work. Our public API surface area is now effectivley 3 pieces: the original JSON-LD component, a function generating Helmet-style props, and this function, which generates plain JSX-style props for `<script>`.
Collaborator
Author
|
@sebastienlabine fyi |
|
@Eyas Looks good! Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23. Some tools such as
next/headrely on a script tag existingdirectly under the
<Head>component. Allowing a react-schemaorg userjust pass the props opaquely to a
<script>tag gives us bothencapsulation while getting the library to work.
Our public API surface area is now effectivley 3 pieces: the original
JSON-LD component, a function generating Helmet-style props, and this
function, which generates plain JSX-style props for
<script>.