Make the examples actually run 100,000 times.#2
Conversation
|
Memo: This actually makes it take really really really long to complete. I'm not sure if it is a great idea, now that testing it some more. Perhaps the right action here is the revise the comment and make it loop some more reasonable amount. |
|
I definitely think making them run multiple times is a good idea. 100k may be a bit much. The target I used for benchmarks was 1 second. So perhaps try getting the PHP implementation to take 1 second, and then put that number of iterations in the example. Thanks! |
|
I found that I wonder if I have an oddly configured PHP that is not behaving correctly to leverage the optimizations? |
|
You're not seeing the optimizations because you don't have the jitfu extension installed, so you're just executing the fallback PHP code... |
|
Should it emit a warning when jitfu ext is missing? Or should it be required(-dev) in composer.json? |
|
No, because more backends then just JitFU are planned on being supported. In fact, there is a PHP backend today that'll generate PHP code back out of it. And I'd like to see others (a virtual machine backend, then perhaps an LLVM backend, etc). JitFU is a requirement for the final compilation today. But not for using the tool. Which is why it's called "Compiler Toolkit". It's not a single compiler with a single target. It's a set of tools to target arbitrary backends. |
This is a simple fix, I release all rights to the modification.
If you'd still need a CLA, please let me know and I'll file one.Filed electronically :)