Skip to content

fix(a11y): enhance labels for destination photos button #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KenTandrian wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(a11y): enhance labels for destination photos button #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68f6dd5
fix(a11y): change labels for destination photos btn
KenTandrian Dec 22, 2025
15e9605
fix(a11y): make individual destination links hidden when not opened
KenTandrian Dec 22, 2025
d9fc034
Merge remote-tracking branch 'origin/main' into a11y/descriptive-labe…
KenTandrian Dec 23, 2025
6ceac38
Merge branch 'google:main' into a11y/descriptive-labels-for-destinati…
KenTandrian Dec 24, 2025
4429def
Merge branch 'google:main' into a11y/descriptive-labels-for-destinati…
KenTandrian Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion static/scenes/modvil/elements/modvil-tracker-photo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class ModvilTrackerPhotoElement extends LitElement {
_href: {type: String},
_author: {type: String},
brand: {type: Boolean},
disabled: {type: Boolean},
};
}

Expand All @@ -59,7 +60,7 @@ class ModvilTrackerPhotoElement extends LitElement {
<div class="inner">
<slot></slot>
<div class="attribution ${this.brand ? 'brand' : ''}">
<a target="_blank" href=${ifDefined(this._href)}>${this._author}</a>
<a aria-hidden="${this.disabled ? 'true' : 'false'}" tabindex="${this.disabled ? '-1' : '0'}" target="_blank" href=${ifDefined(this._href)}>${this._author}</a>
</div>
</div>
`;
Expand Down
4 changes: 3 additions & 1 deletion static/scenes/modvil/elements/modvil-tracker-photos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ class ModvilTrackerStatsElement extends LitElement {
this._photoNode.append(node);
node.offsetLeft; // and forcing layout, important
node.style.transform = null;
node.disabled = !this.open;
});

// Extra control.
Expand Down Expand Up @@ -248,6 +249,7 @@ class ModvilTrackerStatsElement extends LitElement {

node.toggleAttribute('large', !!this.open);
node.setAttribute('appear', '');
node.disabled = !this.open;
this._photoNode.prepend(node);
await node.updateComplete;
await new Promise((resolve) => {
Expand Down Expand Up @@ -277,7 +279,7 @@ class ModvilTrackerStatsElement extends LitElement {
<h1>${d.city}</h1>
<h2>${d.region}</h2>
</div>
<button class="hint button-open" @click=${() => this.open = true}></button>
<button aria-label="${d.city}, ${d.region}, Local Guide images" class="hint button-open" @click=${() => this.open = true}></button>
</div>
<div class="view-open">
<button class="hint button-close" @click=${() => this.open = false}></button>
Expand Down