Skip to content

Conversation

@KenTandrian
Copy link
Collaborator

This PR fixes an accessibility issue in the "Destination Photos" component where the touch target size for the photos was smaller than the minimum required dimensions (48x48dp on Android / 44x44pt on iOS). Previously, only the attribution text at the bottom was clickable.

Changes

  • Expanded Touch Target: Refactored ModvilTrackerPhotoElement to convert the main container (.inner) into an <a> tag. This makes the entire photo card clickable and ensures it meets touch target size requirements.
  • Semantic Structure: Replaced the nested interactive elements with a single block-level link, improving HTML semantics and keyboard navigation.
  • Visual & Focus States: Updated SCSS to ensure the new anchor container maintains the correct visual layout and added hover styles to underline the attribution text when the card is hovered.

Impacted UI components

  • Destination Photos (modvil-tracker-photo).

@KenTandrian
Copy link
Collaborator Author

Before:

touchtarget before

After:

touchtarget after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant