Skip to content

fix(a11y): enhance label on track santa button #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KenTandrian wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(a11y): enhance label on track santa button #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25e1879
fix(a11y): fix santa button to not use nothing
KenTandrian Dec 23, 2025
ad0fb14
fix(a11y): add aria-label to santa cap button
KenTandrian Dec 23, 2025
763e32b
Merge branch 'google:main' into a11y/track-santa-button
KenTandrian Dec 24, 2025
bfec70a
Merge branch 'google:main' into a11y/track-santa-button
KenTandrian Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions static/scenes/modvil/elements/modvil-tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const routeJitterRatio = +localStorage['routeJitter'] || 0;


class ModvilTrackerElement extends LitElement {
static get styles() { return [styles]; }
static get styles() {return [styles];}

static get properties() {
return {
Expand Down Expand Up @@ -370,7 +370,7 @@ class ModvilTrackerElement extends LitElement {
</div>
</div>
<div class="buttons">
<santa-button color="green" class=${this._focusOnSanta ? 'gone' : ''} @click=${this._onFocusSantaClick}>
<santa-button aria-label=${_msg`tracker_track`} color="green" class=${this._focusOnSanta ? 'gone' : ''} @click=${this._onFocusSantaClick}>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 257.22 139.5"><defs><style>.cls-1,.cls-3{fill:#fff;}.cls-1,.cls-4{stroke:#f9f9f9;stroke-miterlimit:10;}.cls-2{fill:#e53935;}.cls-4{fill:none;}</style></defs><title>hat_santa</title><g id="Layer_2" data-name="Layer 2"><g id="ART"><path class="cls-1" d="M55.9,28.21A27.7,27.7,0,1,1,28.21.5,27.69,27.69,0,0,1,55.9,28.21Z"/><path class="cls-2" d="M68.45,28.2l-1,0V139H242.87C242.87,77.8,164.78,28.2,68.45,28.2Z"/><rect class="cls-3" x="44.36" y="83.6" width="212.36" height="55.4" rx="16.37" ry="16.37"/><rect class="cls-4" x="44.36" y="83.6" width="212.36" height="55.4" rx="16.37" ry="16.37"/></g></g></svg>
</santa-button>
</div>
Expand Down
5 changes: 2 additions & 3 deletions static/src/elements/santa-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/

import {html, LitElement} from 'lit-element';
import {nothing} from 'lit-html';
import {ifDefined} from 'lit-html/directives/if-defined';
import * as common from '../../src/core/common.js';
import styles from './santa-button.css';
Expand Down Expand Up @@ -88,8 +87,8 @@ export class SantaButtonElement extends LitElement {
class="${this.color || ''}"
.disabled=${this.disabled}
@click=${this._maybePreventClick}
aria-expanded=${ifDefined(this.ariaExpanded || undefined)}
aria-label=${this.ariaLabel || nothing}>${inner}</button>`;
aria-expanded=${ifDefined(this.ariaExpanded)}
aria-label=${ifDefined(this.ariaLabel)}>${inner}</button>`;
}

focus() {
Expand Down