Conversation
Start migration to allow customizing shard info iteration.
There was a problem hiding this comment.
Summary of Changes
Hello @kralka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This PR begins the migration towards more flexible shard iteration by introducing a new CachedShardInfoIterator class. This class centralizes logic for filtering, limiting, and shuffling shards, which was previously scattered. It also refactors the dataset iteration methods to leverage this new, more customizable iterator.
Highlights
- Introduced CachedShardInfoIterator: A new class that extends ShardInfoIterator to provide advanced control over shard iteration, including caching, filtering by shard_filter, limiting by shards count, limiting by custom_metadata_type_limit, and shuffling.
- Centralized Shard Selection Logic: The shard_paths_dataset method now utilizes CachedShardInfoIterator to handle all shard filtering and limiting, removing duplicated logic.
- Refactored Example Iteration: The as_numpy_iterator method has been updated to use CachedShardInfoIterator and delegates the core example processing to a new helper method, example_iterator_from_shard_iterator, improving modularity.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a CachedShardInfoIterator to centralize and customize shard iteration logic. This is a good refactoring that simplifies methods like shard_paths_dataset and as_numpy_iterator in DatasetIteration. My review includes a suggestion to improve the robustness of metadata handling in the new iterator and a note on some logging that was removed during the refactoring, which might be worth restoring for debuggability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Start migration to allow customizing shard info iteration.