-
Notifications
You must be signed in to change notification settings - Fork 10
Support Keras multi-backend in tinyAES tutorial #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -197,6 +197,23 @@ def convert_to_sedpack(dataset_path: Path, original_files: Path) -> None: | |
| dataset.write_config() | ||
|
|
||
|
|
||
| def process_batch(batch: dict[str, Any]) -> tuple[Any, dict[str, Any]]: | ||
| """Processing of a batch of records. The input is a dictionary of string | ||
| and tensor, the output of this function is a tuple the neural network's | ||
| input (trace) and a dictionary of one-hot encoded expected outputs. | ||
| """ | ||
| # The first neural network was using just the first half of the trace: | ||
| inputs = batch["trace1"] | ||
| outputs = { | ||
| "sub_bytes_in_0": | ||
| keras.ops.one_hot( | ||
| batch["sub_bytes_in"][:, 0], | ||
| num_classes=256, | ||
| ), | ||
| } | ||
| return (inputs, outputs) | ||
|
|
||
|
|
||
| def process_record(record: dict[str, Any]) -> tuple[Any, dict[str, Any]]: | ||
| """Processing of a single record. The input is a dictionary of string and | ||
| tensor, the output of this function is a tuple the neural network's input | ||
|
|
@@ -256,20 +273,32 @@ def train(dataset_path: Path) -> None: | |
| ) | ||
| model.summary() | ||
|
|
||
| train_ds = dataset.as_tfdataset( | ||
| split="train", | ||
| process_record=process_record, | ||
| batch_size=batch_size, | ||
| #file_parallelism=4, | ||
| #parallelism=4, | ||
| ) | ||
| validation_ds = dataset.as_tfdataset( | ||
| split="test", | ||
| process_record=process_record, | ||
| batch_size=batch_size, | ||
| #file_parallelism=4, | ||
| #parallelism=4, | ||
| ) | ||
| match keras.backend.backend(): | ||
| case "tensorflow": | ||
| train_ds = dataset.as_tfdataset( | ||
| split="train", | ||
| process_record=process_record, | ||
| batch_size=batch_size, | ||
| ) | ||
| validation_ds = dataset.as_tfdataset( | ||
| split="test", | ||
| process_record=process_record, | ||
| batch_size=batch_size, | ||
| ) | ||
| case "jax" | "torch": | ||
| train_ds = dataset.as_numpy_iterator_rust_batched( | ||
| split="train", | ||
| process_batch=process_batch, | ||
| batch_size=batch_size, | ||
| ) | ||
| validation_ds = dataset.as_numpy_iterator_rust_batched( | ||
| split="test", | ||
| process_batch=process_batch, | ||
| batch_size=batch_size, | ||
| ) | ||
| case _: | ||
| print(f"TODO support {keras.backend.backend() = }") | ||
| return | ||
|
Comment on lines
+276
to
+301
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| # Train the model. | ||
| _ = model.fit( | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
process_batchfunction is introduced to handle batched processing for JAX backend. It correctly extracts inputs and one-hot encodes thesub_bytes_infor the first byte. This is a good addition for multi-backend support.