Reflect ExtInstSet generation steps of SPIRV-Tools in Android.mk.#190
Conversation
| --extinst-glsl-grammar=$(SPVTOOLS_LOCAL_PATH)/source/extinst.glsl.std.450.grammar.json \ | ||
| --extinst-opencl-grammar=$(SPVTOOLS_LOCAL_PATH)/source/extinst.opencl.std.grammar.json \ | ||
| --core-insts-output=$(1)/core.insts.inc \ | ||
| --glsl-insts-output=$(1)/glsl.std.450.insts.inc \ |
There was a problem hiding this comment.
Can this script be run with a selection of arguments?
i.e. what happens if I were to omit --spirv-core-grammar="".
I ask because this would look a lot better as a set of 3(or 4) rules, 1 per target, rather than one large complicated one. It could also be factored into a single function so you could generate a new rule something like:
There was a problem hiding this comment.
I'm not sure that's the correct way to go because it means to duplicate the Capability enum in the glsl.std.450 & opencl.std grammar, too. That causes synchronization problem. Besides, glsl.std.450 & 'opencl.std` ExtInstSet depend on the core grammar naturally, so I'd prefer that consumers of these two ExtInstSets should refer to the core grammar.
There was a problem hiding this comment.
That's fair, I don't have a strong opinion, it just seems a bit unfortunate to have a single makefile rule that generates 4 different outputs. (And it's fairly conceivable to see it grow in the future)
There was a problem hiding this comment.
;) Sometimes (I mean, here) I feel strong pulse to insert tabs/spaces.
|
+2 from me. |
|
+2 (redundant), depending on KhronosGroup/SPIRV-Tools#174 going in |
antiagainst
force-pushed
the
spirv-tools-build
branch
from
4edde32 to
533ba9b
Compare
3 participants
Counterpart for KhronosGroup/SPIRV-Tools#174.