Skip to content

Always escape values in comments as per specification #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sjs994 merged 2 commits into from
Dec 15, 2022
Merged

Always escape values in comments as per specification #217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c5ab2e
Always escape values in comments as per specification
kostyay Dec 15, 2022
3dc25a4
escape
kostyay Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions go/core/core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ type CommenterOptions struct {
}

func encodeURL(k string) string {
return url.QueryEscape(string(k))
return url.QueryEscape(k)
}

func GetFunctionName(i interface{}) string {
Expand All @@ -71,7 +71,7 @@ func ConvertMapToComment(tags map[string]string) string {
var sb strings.Builder
i, sz := 0, len(tags)

//sort by keys
// sort by keys
sortedKeys := make([]string, 0, len(tags))
for k := range tags {
sortedKeys = append(sortedKeys, k)
Expand All @@ -80,9 +80,9 @@ func ConvertMapToComment(tags map[string]string) string {

for _, key := range sortedKeys {
if i == sz-1 {
sb.WriteString(fmt.Sprintf("%s=%v", encodeURL(key), encodeURL(tags[key])))
sb.WriteString(fmt.Sprintf("%s='%s'", encodeURL(key), encodeURL(tags[key])))
} else {
sb.WriteString(fmt.Sprintf("%s=%v,", encodeURL(key), encodeURL(tags[key])))
sb.WriteString(fmt.Sprintf("%s='%s',", encodeURL(key), encodeURL(tags[key])))
}
i++
}
Expand Down