Skip to content

Add extra validation to create/edit device endpoint #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 1 commit into from
Sep 14, 2023
Merged

Add extra validation to create/edit device endpoint #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions framework/python/src/api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,26 @@ async def save_device(self, request: Request, response: Response):
return self._generate_msg(False, "Invalid JSON received")

def _validate_device_json(self, json_obj):

# Check all required properties are present
if not (DEVICE_MAC_ADDR_KEY in json_obj and
DEVICE_MANUFACTURER_KEY in json_obj and
DEVICE_MODEL_KEY in json_obj
):
return False

# Check length of strings
if len(json_obj.get(DEVICE_MANUFACTURER_KEY)) > 64 or len(
json_obj.get(DEVICE_MODEL_KEY)) > 64:
return False

disallowed_chars = ["/", "\\", "\'", "\"", ";"]
for char in json_obj.get(DEVICE_MANUFACTURER_KEY):
if char in disallowed_chars:
return False

for char in json_obj.get(DEVICE_MODEL_KEY):
if char in disallowed_chars:
return False

return True