Skip to content

Test fixes #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jboddey merged 3 commits into from
Sep 21, 2023
Merged

Test fixes #123

jboddey merged 3 commits into from
Sep 21, 2023

Conversation

@jhughesoti
Copy link
Contributor

@jhughesoti jhughesoti commented Sep 20, 2023

Fixes two test issues:

TLS Module:

  • root_certs are only mounted during build time so no user provided root_certs after install are available for the test. Update mounts root_certs into all test modules for availability during runtime

NMAP Module:

  • Add an allowed port option and update the http config to include 443 for http tests. Http was incorrectly failing on allowed port 443 and needed to have a port allowed since http and https both report the same service name.

@jboddey jboddey merged commit 6bad0dd into dev Sep 21, 2023
@jboddey jboddey deleted the test_fixes branch September 26, 2023 12:30
hitnik pushed a commit that referenced this pull request Jul 22, 2024
@jhughesoti
Test fixes (#123)
7244908 
* Mount root_certs to test containers

* Add allow option to nmap ports
Fix https failure detection in http test

* Remove device certs copy during tls build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noursaidi noursaidi Awaiting requested review from noursaidi

1 more reviewer

@jboddey jboddey jboddey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhughesoti @jboddey