Skip to content

Add check before launching UI #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 2 commits into from
Jan 4, 2024
Merged

Add check before launching UI #216

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e51fd37
Add check before launching UI
jboddey Jan 2, 2024
4df87e6
Switch print to LOGGER
jboddey Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions framework/python/src/core/testrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@
from net_orc import network_orchestrator as net_orc
from test_orc import test_orchestrator as test_orc

from docker.errors import ImageNotFound

# Locate parent directory
current_dir = os.path.dirname(os.path.realpath(__file__))

Expand Down Expand Up @@ -430,16 +432,22 @@ def start_ui(self):

client = docker.from_env()

client.containers.run(
image='test-run/ui',
auto_remove=True,
name='tr-ui',
hostname='testrun.io',
detach=True,
ports={
'80': 8080
}
)
try:
client.containers.run(
image='test-run/ui',
auto_remove=True,
name='tr-ui',
hostname='testrun.io',
detach=True,
ports={
'80': 8080
}
)
except ImageNotFound as ie:
LOGGER.error('An error occured whilst starting the UI. ' +
'Please investigate and try again.')
LOGGER.error(ie)
sys.exit(1)

# TODO: Make port configurable
LOGGER.info('User interface is ready on http://localhost:8080')
Expand Down