322476587: (fix) change to set default selected value on close panel #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofyakurilova
approved these changes
Jan 26, 2024
jboddey
added a commit
that referenced
this pull request
Feb 7, 2024
* Merge dev into main (Release 1.1-alpha) (#182) * Implement PR223 for clean merge into release (#225) * Add guide to identify network interfaces (#214) * Update docs * Add reference to get started guide * Update UI * Increment version * Add edit device endpoint (#227) Signed-off-by: J Boddey <boddey@google.com> * Fix merge conflict and fix pylint * Update README.md (#232) Signed-off-by: J Boddey <boddey@google.com> * Add error handling to version check (#230) * Add report to session (#234) * Update UI: (#240) - change connection settings to allow use one port - [a11y] add the name of testrun to stop testrun dialog * 322476587: (fix) change to set default selected value on close panel (#245) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fix UI build directory --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: sofyakurilova <sonnycactus@gmail.com> Co-authored-by: Olga Mardvilko <omardvilko@mail.ru> Co-authored-by: Volha Mardvilka <mardvilka@google.com>
hitnik
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Merge dev into main (Release 1.1-alpha) (#182) * Implement PR223 for clean merge into release (#225) * Add guide to identify network interfaces (#214) * Update docs * Add reference to get started guide * Update UI * Increment version * Add edit device endpoint (#227) Signed-off-by: J Boddey <boddey@google.com> * Fix merge conflict and fix pylint * Update README.md (#232) Signed-off-by: J Boddey <boddey@google.com> * Add error handling to version check (#230) * Add report to session (#234) * Update UI: (#240) - change connection settings to allow use one port - [a11y] add the name of testrun to stop testrun dialog * 322476587: (fix) change to set default selected value on close panel (#245) Co-authored-by: Volha Mardvilka <mardvilka@google.com> * Fix UI build directory --------- Signed-off-by: J Boddey <boddey@google.com> Co-authored-by: sofyakurilova <sonnycactus@gmail.com> Co-authored-by: Olga Mardvilko <omardvilko@mail.ru> Co-authored-by: Volha Mardvilka <mardvilka@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ticket: 322476587
fix: change to set default selected value on close panel
Video before changes
https://screencast.googleplex.com/cast/NTM3OTcxNTkzMzE0MzA0MHw0ZTdiNzc5NC1lNQ
Video after changes
https://screencast.googleplex.com/cast/NTg1MTI5NjQ0NjgwODA2NHxlZDk2ZmJiNS0xYw
Screenshot after changes
https://screenshot.googleplex.com/AWBzuewycuAMFwf.png