Feature/dev UI #260
Merged
Feature/dev UI #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jboddey
approved these changes
Feb 7, 2024
Contributor
|
@sofyakurilova I have found a bug in this PR: This results in invalid interfaces being saved in the system config. The UI should still return the actual interface name to the API. |
* Fix styles for helperbird * Fix node version
Adds ESLint workflow
* Adds store for system config * Adds error message callout if selected port is missing
…t is saved (#253) Co-authored-by: Volha Mardvilka <mardvilka@google.com>
sofyakurilova
force-pushed
the
feature/dev_ui
branch
from
3843311 to
a41c40d
Compare
Contributor
|
The bug is now resolved. @KrystsinaT could you verify perhaps? |
jboddey
approved these changes
Feb 8, 2024
hitnik
pushed a commit
that referenced
this pull request
Jul 22, 2024
* Update UI - feat store - feat start test run from devices page * Fix styles for helperbird (#243) * Fix styles for helperbird * Fix node version * Adds ESLint workflow (#248) Adds ESLint workflow * Feature/317232143 (#247) * Adds store for system config * Adds error message callout if selected port is missing * Set snack bar duration to 0 to prevent auto closing (#250) * Adds trap focus on connection settings panel (#251) * Disables settings save button if there is no interfaces (#252) * 323349282: (fix) [ui] change logic to hide message if only device port is saved (#253) Co-authored-by: Volha Mardvilka <mardvilka@google.com> --------- Co-authored-by: Olga Mardvilko <omardvilko@mail.ru> Co-authored-by: Volha Mardvilka <mardvilka@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge dev_ui with dev after release