Skip to content

326951948: (fix) [a11y] add accessible names for welcome modal and buttons #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlgaMardvilko merged 1 commit into from
Mar 1, 2024
Merged

326951948: (fix) [a11y] add accessible names for welcome modal and buttons #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ <h2>Welcome to Testrun!</h2>
color="primary"
mat-button
type="button"
aria-label="Download new version"
(click)="cancelOnDownload()">
Download
</a>
Expand All @@ -88,7 +89,7 @@ <h2>Welcome to Testrun!</h2>
href="https://policies.google.com/technologies/partner-sites"
target="_blank"
class="message-link"
aria-label="Terms of service"
aria-label="Terms of service here"
>here</a
>.
</app-callout>
Expand All @@ -109,6 +110,7 @@ <h2>Welcome to Testrun!</h2>
class="confirm-button"
color="primary"
mat-raised-button
aria-label="OK and Proceed to Testrun"
type="button">
OK
</button>
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/components/version/version.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export class VersionComponent implements OnInit, OnDestroy {

openConsentDialog(version: Version) {
const dialogRef = this.dialog.open(ConsentDialogComponent, {
ariaLabel: 'Consent dialog',
ariaLabel: 'Welcome to Testrun modal window',
data: version,
autoFocus: true,
hasBackdrop: true,
Expand Down