Skip to content

326193923: (fix) change to prevent the callout for step 1 blinks on loading/reloading the page #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlgaMardvilko merged 1 commit into from
Mar 7, 2024
Merged

326193923: (fix) change to prevent the callout for step 1 blinks on loading/reloading the page #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions modules/ui/src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,19 +114,11 @@ export class AppComponent implements OnInit {

ngOnInit(): void {
this.systemStatus$ = this.testRunService.systemStatus$.pipe(
tap(() => (this.isStatusLoaded = true))
tap(() => (this.isStatusLoaded = true)),
shareReplay({ refCount: true, bufferSize: 1 })
);

this.isTestrunStarted$ = this.testRunService.isTestrunStarted$;

this.hasConnectionSetting$.pipe(
tap(result => {
if (result !== null) {
this.isConnectionSettingsLoaded = true;
}
}),
shareReplay({ refCount: true, bufferSize: 1 })
);
}

navigateToDeviceRepository(): void {
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/pages/devices/device-repository.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<ng-container *ngIf="viewModel$ | async as vm">
<ng-container *ngIf="vm.devices.length > 0; else empty">
<mat-toolbar class="device-repository-toolbar">
<h2 class="title">Devices {{ vm.selectedDevice === null }}</h2>
<h2 class="title">Devices</h2>
<ng-container *ngTemplateOutlet="addDeviceButton"></ng-container>
</mat-toolbar>
<div class="device-repository-content">
Expand Down
4 changes: 2 additions & 2 deletions modules/ui/src/app/store/state.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export interface SharedState {
//app, testrun
isTestrunStarted?: boolean;
//app, settings
hasConnectionSettings: boolean;
hasConnectionSettings: boolean | null;
// app, devices
isOpenAddDevice: boolean;
}
Expand All @@ -58,7 +58,7 @@ export const initialAppComponentState: AppComponentState = {
};

export const initialSharedState: SharedState = {
hasConnectionSettings: false,
hasConnectionSettings: null,
isOpenAddDevice: false,
hasDevices: false,
devices: [],
Expand Down