Skip to content

328175839: (fix) [a11Y] change to set focus on opening the settings panel #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlgaMardvilko merged 1 commit into from
Mar 18, 2024
Merged

328175839: (fix) [a11Y] change to set focus on opening the settings panel #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/ui/src/app/app.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ <h1 class="main-heading">Testrun</h1>
#settingsDrawer
mode="over"
position="end"
autoFocus="#setting-panel-close-button"
class="settings-drawer">
<app-general-settings
#settings
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/components/version/consent-dialog/consent-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ <h2>Welcome to Testrun!</h2>
href="https://policies.google.com/technologies/partner-sites"
target="_blank"
class="message-link"
aria-label="Terms of service here"
aria-label="here on Google Privacy & Terms page"
>here</a
>.
</app-callout>
Expand Down
1 change: 1 addition & 0 deletions modules/ui/src/app/pages/settings/general-settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ <h2 class="settings-drawer-header-title">System settings</h2>
<button
(click)="closeSetting(EventType.Close)"
aria-label="close"
id="setting-panel-close-button"
class="settings-drawer-header-button"
mat-button>
<mat-icon class="close-button-icon" svgIcon="close"></mat-icon>
Expand Down