Skip to content

329834205: (fix) apply Angular tooltip to fix the long text issue on hover #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlgaMardvilko merged 2 commits into from
Mar 21, 2024
Merged

329834205: (fix) apply Angular tooltip to fix the long text issue on hover #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c359d17
329834205: (fix) apply Angular tooltip to fix the long text issue on …
OlgaMardvilko Mar 21, 2024
53b3dc1
329834205: (fix) change words Test Run to Testrun
OlgaMardvilko Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@
*ngIf="data"
[data]="data"
[href]="data.report"
title="Download pdf for Test Run # {{ getTestRunId(data) }}">
title="Download pdf for Testrun # {{ getTestRunId(data) }}">
<ng-content></ng-content>
</app-download-report>
3 changes: 0 additions & 3 deletions modules/ui/src/app/components/download-report-pdf/download-report-pdf.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,6 @@ describe('DownloadReportComponent', () => {
expect(downloadReportLink.download).toEqual(
'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20'
);
expect(downloadReportLink.title).toEqual(
'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20'
);
});
});
});
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/components/download-report-zip/download-report-zip.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*ngIf="data"
[data]="data"
[href]="getZipLink(data)"
title="Download zip file for Test Run # {{ getTestRunId(data) }}">
title="Download zip file for Testrun # {{ getTestRunId(data) }}">
<mat-icon class="download-report-icon" fontSet="material-symbols-outlined">
archive
</mat-icon>
Expand Down
3 changes: 0 additions & 3 deletions modules/ui/src/app/components/download-report-zip/download-report-zip.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ describe('DownloadReportComponent', () => {
expect(downloadReportLink.download).toEqual(
'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20'
);
expect(downloadReportLink.title).toEqual(
'Download zip file for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20'
);
});
});
});
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/components/download-report/download-report.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
[download]="getReportTitle(data)"
[href]="href"
target="_blank"
[title]="title">
[matTooltip]="title">
<ng-content></ng-content>
</a>
</ng-container>
5 changes: 1 addition & 4 deletions modules/ui/src/app/components/download-report/download-report.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ describe('DownloadReportComponent', () => {
beforeEach(() => {
component.data = MOCK_PROGRESS_DATA_COMPLIANT;
component.title =
'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20';
'Download pdf for Testrun # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20';
component.href = MOCK_PROGRESS_DATA_COMPLIANT.report;

fixture.detectChanges();
Expand All @@ -94,9 +94,6 @@ describe('DownloadReportComponent', () => {
expect(downloadReportLink.download).toEqual(
'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20'
);
expect(downloadReportLink.title).toEqual(
'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20'
);
});
});
});
Expand Down
3 changes: 2 additions & 1 deletion modules/ui/src/app/components/download-report/download-report.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@
import { ChangeDetectionStrategy, Component, Input } from '@angular/core';
import { TestrunStatus } from '../../model/testrun-status';
import { CommonModule, DatePipe } from '@angular/common';
import { MatTooltipModule } from '@angular/material/tooltip';
import { ReportActionComponent } from '../report-action/report-action.component';

@Component({
selector: 'app-download-report',
templateUrl: './download-report.component.html',
styleUrls: ['./download-report.component.scss'],
standalone: true,
imports: [CommonModule],
imports: [CommonModule, MatTooltipModule],
providers: [DatePipe],
changeDetection: ChangeDetectionStrategy.OnPush,
})
Expand Down
2 changes: 1 addition & 1 deletion modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<a
class="delete-report-button"
href="#"
title="Delete report for Test Run # {{ getTestRunId(data) }}"
matTooltip="Delete report for Testrun # {{ getTestRunId(data) }}"
(click)="deleteReport($event)">
<ng-content></ng-content>
</a>
Expand Down
3 changes: 2 additions & 1 deletion modules/ui/src/app/pages/reports/components/delete-report/delete-report.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@ import { MatDialog } from '@angular/material/dialog';
import { DeleteFormComponent } from '../../../../components/delete-form/delete-form.component';
import { takeUntil } from 'rxjs/internal/operators/takeUntil';
import { Subject } from 'rxjs';
import { MatTooltipModule } from '@angular/material/tooltip';

@Component({
selector: 'app-delete-report',
standalone: true,
imports: [CommonModule, MatButtonModule],
imports: [CommonModule, MatButtonModule, MatTooltipModule],
templateUrl: './delete-report.component.html',
styleUrls: ['./delete-report.component.scss'],
providers: [DatePipe],
Expand Down
3 changes: 0 additions & 3 deletions modules/ui/src/app/pages/testrun/progress.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,9 +539,6 @@ describe('ProgressComponent', () => {
expect(link.download).toEqual(
'delta_03-din-cpu_1.2.2_compliant_22_jun_2023_9:20'
);
expect(link.title).toEqual(
'Download pdf for Test Run # Delta 03-DIN-CPU 1.2.2 22 Jun 2023 9:20'
);
});
});

Expand Down