Skip to content

330867613: (feat) change start testrun icon on device tile #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OlgaMardvilko merged 1 commit into from
Apr 9, 2024
Merged

330867613: (feat) change start testrun icon on device tile #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/ui/src/app/app.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ import {
selectInterfaces,
selectMenuOpened,
} from './store/selectors';
import { MatIconTestingModule } from '@angular/material/icon/testing';

describe('AppComponent', () => {
let component: AppComponent;
Expand Down Expand Up @@ -111,6 +112,7 @@ describe('AppComponent', () => {
MatSidenavModule,
BypassComponent,
CalloutComponent,
MatIconTestingModule,
],
providers: [
{ provide: TestRunService, useValue: mockService },
Expand Down
5 changes: 5 additions & 0 deletions modules/ui/src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ import { GeneralSettingsComponent } from './pages/settings/general-settings.comp
import { AppStore } from './app.store';

const DEVICES_LOGO_URL = '/assets/icons/devices.svg';
const DEVICES_RUN_URL = '/assets/icons/device_run.svg';
const REPORTS_LOGO_URL = '/assets/icons/reports.svg';
const TESTRUN_LOGO_URL = '/assets/icons/testrun_logo_small.svg';
const TESTRUN_LOGO_COLOR_URL = '/assets/icons/testrun_logo_color.svg';
Expand Down Expand Up @@ -94,6 +95,10 @@ export class AppComponent implements OnInit {
'devices',
this.domSanitizer.bypassSecurityTrustResourceUrl(DEVICES_LOGO_URL)
);
this.matIconRegistry.addSvgIcon(
'device_run',
this.domSanitizer.bypassSecurityTrustResourceUrl(DEVICES_RUN_URL)
);
this.matIconRegistry.addSvgIcon(
'reports',
this.domSanitizer.bypassSecurityTrustResourceUrl(REPORTS_LOGO_URL)
Expand Down
4 changes: 1 addition & 3 deletions modules/ui/src/app/components/device-item/device-item.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@
attr.aria-label="Start new testrun for device {{ label }}"
class="button-start"
mat-flat-button>
<mat-icon class="button-start-icon" fontSet="material-icons-outlined">
play_arrow</mat-icon
>
<mat-icon class="button-start-icon" [svgIcon]="'device_run'"></mat-icon>
</button>
</div>
3 changes: 1 addition & 2 deletions modules/ui/src/app/components/device-item/device-item.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,8 @@ $border-radius: 12px;

.button-start-icon {
margin: 0;
width: 24px;
width: 30px;
height: 24px;
font-size: 24px;
}

.device-item {
Expand Down
13 changes: 13 additions & 0 deletions modules/ui/src/assets/icons/device_run.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions modules/ui/src/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ body {
background: $dark-grey;
}

.button-start {
&:hover,
&:focus-visible {
.button-start-icon path {
fill: $white;
}
}
}

.app-sidebar-button-active .mat-icon path {
fill: $white;
}
Expand Down