Skip to content

Fix bug with ARP inspection test #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 2 commits into from
Apr 4, 2024
Merged

Fix bug with ARP inspection test #369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a89462e
Allow ARP from 0.0.0.0
jboddey Apr 4, 2024
6186938
Fix logic
jboddey Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions modules/test/conn/python/src/connection_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,11 @@ def _connection_switch_arp_inspection(self):

# Check MAC address matches IP address
if (arp_packet.hwsrc == self._device_mac and
arp_packet.psrc != self._device_ipv4_addr):
(arp_packet.psrc != self._device_ipv4_addr
and arp_packet.psrc != '0.0.0.0')):
LOGGER.info(f'Bad ARP packet detected for MAC: {self._device_mac}')
LOGGER.info(f'''ARP packet from IP {arp_packet.psrc} does not match
{self._device_ipv4_addr}''')
LOGGER.info(f'''ARP packet from IP {arp_packet.psrc}
does not match {self._device_ipv4_addr}''')
return False, 'Device is sending false ARP response'

if no_arp:
Expand Down