Skip to content

Fix bug with deleting reports #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 4 commits into from
Apr 5, 2024
Merged

Fix bug with deleting reports #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a89462e
Allow ARP from 0.0.0.0
jboddey Apr 4, 2024
6186938
Fix logic
jboddey Apr 4, 2024
5eb0a2b
Fix deleting report
jboddey Apr 4, 2024
c67e634
Merge branch 'dev' into bug/delete_report
jboddey Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/python/src/common/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ def get_reports(self):

def remove_report(self, timestamp: datetime):
for report in self.reports:
if report.get_started() == timestamp:
if report.get_started().strftime('%Y-%m-%dT%H:%M:%S') == timestamp:
self.reports.remove(report)
break
return

def to_dict(self):
"""Returns the device as a python dictionary. This is used for the
Expand Down
1 change: 1 addition & 0 deletions framework/python/src/core/testrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ def delete_report(self, device: Device, timestamp):
if report_folder == timestamp:
shutil.rmtree(os.path.join(reports_folder, report_folder))
device.remove_report(timestamp)
LOGGER.debug('Successfully deleted the report')
return True

return False
Expand Down