Skip to content

Fix bug with version number if no internet connection is available #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 1 commit into from
Jun 27, 2024
Merged

Fix bug with version number if no internet connection is available #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions framework/python/src/api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,9 @@ async def get_version(self, response: Response):

# Check OK response was received
if version_check.status_code != 200:
response.status_code = 500
LOGGER.debug(version_check.content)
LOGGER.error("Failed to fetch latest version")
response.status_code = 200
return json_response

# Extract version number from response, removing the leading 'v'
Expand All @@ -359,7 +359,7 @@ async def get_version(self, response: Response):

return json_response
except Exception as e: # pylint: disable=W0703
response.status_code = 500
response.status_code = 200
LOGGER.error("Failed to fetch latest version")
LOGGER.debug(e)
return json_response
Expand Down