Skip to content

Bug/modbus result #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 1 commit into from
Jul 9, 2024
Merged

Bug/modbus result #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions modules/test/protocol/python/src/protocol_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,21 @@ def _protocol_valid_modbus(self, config):
# Extract basic device connection information
modbus = Modbus(log=LOGGER, device_ip=self._device_ipv4_addr, config=config)
results = modbus.validate_device()
result_status = None
result_description = ''
result_details = results[1]

# Determine results and return proper messaging and details
if results[0] is None:
result = ('Feature Not Detected',
'Device did not respond to Modbus connection')
result_status = 'Feature Not Detected'
result_description = 'Device did not respond to Modbus connection'
elif results[0]:
result = True, 'Valid modbus communication detected'
result_status = True
result_description = 'Valid modbus communication detected'
else:
result = False, 'Failed to confirm valid modbus communication'
return result, results[1]
result_status = False
result_description = 'Failed to confirm valid modbus communication'
return result_status, result_description, result_details

def get_local_ip(self, interface_name):
try:
Expand Down