Skip to content

Show tooltip only on keyboard or hover #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Jul 17, 2024
Merged

Show tooltip only on keyboard or hover #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions modules/ui/src/app/components/download-report-zip/download-report-zip.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ describe('DownloadReportZipComponent', () => {
expect(spyOnShow).toHaveBeenCalled();
});

it('should be shown on focusin', () => {
it('should be shown on keyup', () => {
const spyOnShow = spyOn(component.tooltip, 'show');
fixture.nativeElement.dispatchEvent(new Event('focusin'));
fixture.nativeElement.dispatchEvent(new Event('keyup'));

expect(spyOnShow).toHaveBeenCalled();
});
Expand All @@ -185,9 +185,9 @@ describe('DownloadReportZipComponent', () => {
expect(spyOnHide).toHaveBeenCalled();
});

it('should be hidden on focusout', () => {
it('should be hidden on keydown', () => {
const spyOnHide = spyOn(component.tooltip, 'hide');
fixture.nativeElement.dispatchEvent(new Event('focusout'));
fixture.nativeElement.dispatchEvent(new Event('keydown'));

expect(spyOnHide).toHaveBeenCalled();
});
Expand Down
4 changes: 2 additions & 2 deletions modules/ui/src/app/components/download-report-zip/download-report-zip.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,13 @@ export class DownloadReportZipComponent
readonly tabIndex = 0;

@HostListener('mouseenter')
@HostListener('focusin', ['$event'])
@HostListener('keyup', ['$event'])
onEvent(): void {
this.tooltip.show();
}

@HostListener('mouseleave')
@HostListener('focusout', ['$event'])
@HostListener('keydown', ['$event'])
outEvent(): void {
this.tooltip.hide();
}
Expand Down