Skip to content

Conversation

@MariusBaldovin
Copy link
Contributor

@MariusBaldovin MariusBaldovin commented Aug 14, 2024

Added tests for certificate endpoints:

  • GET request: 200 (OK)
  • POST request: 200 (OK), 400 (Bad Request), 409 (Already Exists)
  • DELETE request: 200 (OK), 400 (Bad Request), 404(Not Found)

Added tests for report endpoints:

  • GET request: 200 (OK), 404(Not Found)
  • POST request: 200 (OK), 404(Not Found)
  • DELETE request: 200 (OK), 400 (Bad Request), 404 (Not Found), 500 (Server Error)

Updated api.py:

  • added 404 response in get_results if report is missing
  • added 400 response in delete_report if timestamp format is incorrect

@jboddey
Copy link
Contributor

jboddey commented Aug 15, 2024

You have a pylint issue to fix

@jboddey jboddey marked this pull request as ready for review August 22, 2024 16:00
@jboddey jboddey self-requested a review August 22, 2024 16:00
@jboddey
Copy link
Contributor

jboddey commented Aug 22, 2024

@MariusBaldovin 2 issues. 1) There are some tests in API that are failing 2) We need to figure out why the API tests say that it has passed even though tests have failed.

@MariusBaldovin
Copy link
Contributor Author

@jboddey I will investigate this issue. In my dev branch, all the tests passed after the last commit.

@jboddey jboddey merged commit b16a444 into google:dev Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants