Skip to content

Overlapping of error messages in Device menu #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Aug 26, 2024
Merged

Overlapping of error messages in Device menu #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...ges/devices/components/device-qualification-from/device-qualification-from.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ <h2 class="device-qualification-form-header-title">{{ data.title }}</h2>
<mat-hint>Please enter device manufacturer name</mat-hint>
<mat-error
*ngIf="manufacturer.hasError('invalid_format')"
class="error-multiline"
role="alert"
aria-live="assertive">
<span
Expand All @@ -72,6 +73,7 @@ <h2 class="device-qualification-form-header-title">{{ data.title }}</h2>
<mat-hint>Please enter device name</mat-hint>
<mat-error
*ngIf="model.hasError('invalid_format')"
class="error-multiline"
role="alert"
aria-live="assertive">
<span
Expand Down
8 changes: 7 additions & 1 deletion ...ges/devices/components/device-qualification-from/device-qualification-from.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ $form-height: 993px;
gap: 10px;
height: 100%;
overflow: hidden;
&:last-of-type {
&:has(.device-qualification-form-summary-container) {
grid-template-rows: min-content min-content 1fr min-content;
}
}
Expand Down Expand Up @@ -283,6 +283,11 @@ $form-height: 993px;
background: $white;
}

.manufacturer-field:has(.error-multiline),
.model-field:has(.error-multiline) {
padding-bottom: 14px;
}

@container qualification-form (height < 870px) {
.device-qualification-form-page {
overflow: scroll;
Expand All @@ -291,6 +296,7 @@ $form-height: 993px;
}
}
}

@container qualification-form (height < 580px) {
.device-qualification-form-page {
overflow: scroll;
Expand Down