Skip to content

Change response of device config steps to match UI expectations #721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 3 commits into from
Aug 29, 2024
Merged

Change response of device config steps to match UI expectations #721

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8902b6
Change API response for device profile
jboddey Aug 27, 2024
67d26bb
Merge branch 'dev' into bug/device_profile
jboddey Aug 29, 2024
f17f7ad
Merge branch 'dev' into bug/device_profile
jboddey Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions framework/python/src/api/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,24 +715,9 @@ async def get_results(self, request: Request, response: Response, device_name,
response.status_code = 404
return self._generate_msg(False, "Test results could not be found")

async def get_devices_profile(self,
request: Request,
response: Response,
step: int = 1):
async def get_devices_profile(self):
"""Device profile questions"""

all_steps = len(self._device_profile)

try:
questions = self._device_profile[step-1]
if step < all_steps:
questions["next_step"] = f"{request.url.path}?step={step + 1}"
return questions

except IndexError:
response.status_code = status.HTTP_404_NOT_FOUND
return self._generate_msg(
False, f"Step {step} does not exist.")
return self._device_profile

def _validate_device_json(self, json_obj):

Expand Down