Skip to content

Scroll is not displayed when to zoom the page with opened modal #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofyakurilova merged 1 commit into from
Sep 5, 2024
Merged

Scroll is not displayed when to zoom the page with opened modal #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...ges/devices/components/device-qualification-from/device-qualification-from.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
@import 'src/theming/variables';

$form-min-width: 732px;
$form-height: 993px;

:host {
container-type: size;
Expand Down
16 changes: 16 additions & 0 deletions ...pages/devices/components/device-qualification-from/device-qualification-from.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
AfterViewInit,
Component,
ElementRef,
HostListener,
Inject,
OnDestroy,
OnInit,
Expand Down Expand Up @@ -115,6 +116,7 @@ interface DialogData {
export class DeviceQualificationFromComponent
implements OnInit, AfterViewInit, OnDestroy
{
readonly FORM_HEIGHT = 993;
readonly TestingType = TestingType;
readonly DeviceView = DeviceView;
readonly ProgramType = ProgramType;
Expand Down Expand Up @@ -179,6 +181,11 @@ export class DeviceQualificationFromComponent
return device1 && device2 && this.compareDevices(device1, device2);
}

@HostListener('window:resize', ['$event'])
onResize() {
this.setDialogHeight();
}

constructor(
private fb: FormBuilder,
private deviceValidators: DeviceValidators,
Expand Down Expand Up @@ -556,4 +563,13 @@ export class DeviceQualificationFromComponent
}
return true;
}

private setDialogHeight(): void {
const windowHeight = window.innerHeight;
if (windowHeight < this.FORM_HEIGHT) {
this.element.nativeElement.style.height = '100vh';
} else {
this.element.nativeElement.style.height = this.FORM_HEIGHT + 'px';
}
}
}