Skip to content

Fixed the failing unit tests #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboddey merged 1 commit into from
Oct 21, 2024
Merged

Fixed the failing unit tests #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion testing/unit/tls/reports/tls_report_ext_local.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,4 +126,4 @@ <h1>Extensions</h1>

</tbody>
</table>


2 changes: 1 addition & 1 deletion testing/unit/tls/reports/tls_report_local.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,4 +141,4 @@ <h1>Issuer</h1>

</tbody>
</table>


2 changes: 1 addition & 1 deletion testing/unit/tls/reports/tls_report_no_cert_local.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ <h1>TLS Module</h1>
<div class="callout-container info">
<div class="icon"></div>
No TLS certificates found on the device
</div>
</div>
11 changes: 10 additions & 1 deletion testing/unit/tls/tls_module_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,6 @@ def tls_module_report_test(self):
monitor_capture_file=pcap_file,
tls_capture_file=pcap_file)
report_out_path = tls.generate_module_report()

with open(report_out_path, 'r', encoding='utf-8') as file:
report_out = file.read()

Expand Down Expand Up @@ -362,6 +361,11 @@ def tls_module_report_ext_test(self):
with open(LOCAL_REPORT_EXT, 'r', encoding='utf-8') as file:
report_local = file.read()

# Copy the generated html report to a new file
new_report_name = 'tls_report_ext_local.html'
new_report_path = os.path.join(OUTPUT_DIR, new_report_name)
shutil.copy(report_out_path, new_report_path)

self.assertEqual(report_out, report_local)

def tls_module_report_no_cert_test(self):
Expand All @@ -385,6 +389,11 @@ def tls_module_report_no_cert_test(self):
with open(LOCAL_REPORT_NO_CERT, 'r', encoding='utf-8') as file:
report_local = file.read()

# Copy the generated html report to a new file
new_report_name = 'tls_report_no_cert_local.html'
new_report_path = os.path.join(OUTPUT_DIR, new_report_name)
shutil.copy(report_out_path, new_report_path)

self.assertEqual(report_out, report_local)

def generate_tls_traffic(self,
Expand Down