Skip to content

Conversation

@MariusBaldovin
Copy link
Contributor

@MariusBaldovin MariusBaldovin commented Dec 4, 2024

Report is not created:
error
error_2

The issue is that "style" attribute is accessed directly (el["style"])
style

When a div element doesn't have "style" the error is thrown:
else

Added id attribute for tls module to be used instead of style and using get instead of directly accessing the attribute to avoid errors when id is not present in the div element.

tls_module.py was printing twice for the first port number:
tls1
tls2

This was fixed by removing summary_table from line 252 as it's content is already added into cert_table in line 246

@jboddey jboddey requested a review from hitnik December 5, 2024 09:21
@MariusBaldovin MariusBaldovin changed the title Fixed no "style" key error Report is not created Dec 5, 2024
@MariusBaldovin MariusBaldovin marked this pull request as ready for review December 5, 2024 10:20
@jboddey jboddey merged commit 2e34fd3 into google:release/v2.1 Dec 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants