Define valid GTFS-realtime version numbers#130
Merged
barbeau merged 2 commits intogoogle:masterfrom Jan 17, 2019
Merged
Conversation
* gtfs_realtime_version is a string in the Protocol Buffer gtfs-realtime.proto file, and therefore producers can populate this field with a number of different possible values. Previously, the exact GTFS-realtime version format hasn't been explicitly defined anywhere, and as a result producers have published a variety of interpretations (e.g., 1.0, 1) * This proposal strictly defines what the allowed GTFS-realtime version numbers are so that consumers can do exact string matching to determine which GTFS-realtime version the producer is publishing
barbeau
added
the
GTFS Realtime
Contributor
Author
|
This pull request has been open for more than one week, so per the Official Process I'm calling for a vote. Vote will be closed on Tuesday January 15th at 23:59:59 UTC. |
|
+1 |
7 similar comments
|
+1 |
Contributor
|
+1 |
Contributor
|
+1 |
|
+1 |
|
+1 |
|
+1 |
|
+1 |
Contributor
Author
|
Voting is closed on this proposal and the results are:
So it passes! Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gtfs_realtime_versionis a string in the Protocol Buffer gtfs-realtime.proto file, and therefore producers can populate this field with a number of different possible values. Previously, the exact allowed GTFS-realtime version format hasn't been explicitly defined in a single location, and as a result producers have published a variety of interpretations (e.g., 1.0, 1).This proposal strictly defines what the allowed GTFS-realtime version numbers are so that consumers can do exact string matching to determine which GTFS-realtime version the producer is publishing and producers have better guidance for the values they should be using.
Valid versions are defined as
2.0and1.0. The .proto file currently lists2.0as the version, and prior to that1.0was defined. Based on our analysis, 37 feeds are using1.0, 4 are using2.0and 4 agencies are using other values, so this aligns with the majority of values currently in use.Announced on the GTFS-realtime Google Group at https://groups.google.com/forum/#!topic/gtfs-realtime/7g8inwuIpKA.