Proposal: Label GTFS-RT ADDED trips as not fully specified#230
Merged
barbeau merged 2 commits intogoogle:masterfrom Jul 15, 2020
Merged
Proposal: Label GTFS-RT ADDED trips as not fully specified#230barbeau merged 2 commits intogoogle:masterfrom
barbeau merged 2 commits intogoogle:masterfrom
Conversation
barbeau
added
the
GTFS Realtime
Contributor
|
+1 OpenGeo |
|
Awesome, thanks Sean! Do you think we could add an analogous comment in the proto file around line ~615 where ADDED is defined? |
|
+1 IBI |
Contributor
Author
|
@jamespfennell Thanks for pointing that out! I forgot that, and just added the same text in the .proto file in ec976f2. |
Contributor
|
+1 Transit App |
Contributor
|
+1 @mbta |
|
+1 Kisio |
|
+1 Google |
Contributor
Author
|
This pull request has been open for more than one week, so per the Official Process I'm calling for a vote. Vote will be closed on Monday July 13th at 23:59:59 UTC. @skinkie, @jamespfennell, @juanborre, @paulswartz, @prhod, @tleboulenge you all expressed support above, so you can officially vote with another comment now. |
Contributor
|
+1 OpenGeo |
Contributor
|
+1 |
2 similar comments
Contributor
|
+1 |
|
+1 |
|
+1 Kisio |
|
+1 Metro Transit (Minneapolis) |
Contributor
Author
|
The vote has closed, and here are the results:
So it passes! Thanks all! |
barbeau
added a commit
to MobilityData/GTFS_Realtime_Best-Practices
that referenced
this pull request
Apr 23, 2021
Matches 9f4196f and google/transit changes for ADDED in google/transit#230.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given existing discussions around how to add or modify trips in GTFS-RT (1) (2) (3), I hope one thing we can all agree upon is that we don't currently agree upon how
ADDEDtrips are produced or consumed.This proposal puts a label on the
ADDEDenumeration to make this lack of agreement clear to newcomers to the spec while we discuss how these concepts should be represented, similar to how theDIFFERENTIALfeature is currently labeled in the GTFS-RT spec.cc @paulswartz @gcamp @skinkie @Bertware @tleboulenge @darylweinberg @juanborre @hbruch @nathan-reynolds @lauramatson
Posted to the Google Group at https://groups.google.com/forum/#!topic/gtfs-realtime/p8pXNzGOafQ.