fix: Add extensions to TripProperties, remove extra comment#238
Merged
barbeau merged 1 commit intogoogle:masterfrom Aug 10, 2020
Merged
fix: Add extensions to TripProperties, remove extra comment#238barbeau merged 1 commit intogoogle:masterfrom
barbeau merged 1 commit intogoogle:masterfrom
Conversation
This is an editorial follow-up to google#221 to fix two items: * New messages should have the extensions fields to allow 3rd party and internal extensions - this commit adds these fields * An erroneous comment was added that labeled schedule_relationship as experimental - this commit removes it
barbeau
referenced
this pull request
Aug 7, 2020
* Support DUPLICATED trips in GTFS-RT * Revert deprecation of ADDED * Remove auto-format change * Better explanation of "forbidden" * Add experimental labels for message/fields * Add experimental labels for field * Add experimental label for message * Clarify DUPLICATED use with VehiclePosition * Clarify that true frequency-based trips can't be duplicated * Explicitly define how the duplicated trip schedule and RT values are calculated * docs: Add migration guide for transition from ADDED to DUPLICATED trips * docs: Normalize comments in code * docs: Allow trip.trip_id->trip_properties.trip_id link in migration guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an editorial follow-up to #221 to fix two items:
TripPropertiesexperimental- this commit removes it