Change type of headway_secs to positive integer#249
Merged
aababilov merged 1 commit intogoogle:masterfrom Oct 2, 2020
Merged
Conversation
headway_secs=0 does not have a physical meaning. This must be the time between departures for the same stop for a single trip.
Contributor
Author
|
Also, Google shows a validation error for feeds that give headway_secs=0. |
gcamp
approved these changes
Sep 28, 2020
timMillet
reviewed
Sep 29, 2020
Contributor
timMillet
left a comment
timMillet
left a comment
There was a problem hiding this comment.
I agree with the proposition. However, "Positive Integer" is not defined in the Field Types section and should be added for consistency.
Contributor
Author
|
You are right, it is missing in the section. However, it is already used for pathways.traversal_time. I will add the definition in a separate pull request. |
Contributor
Author
|
#251 for the new types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
headway_secs=0 does not have a physical meaning. This must be the time between departures for the same stop for a single trip.