Clarification of stop_times.stop_id#258
Merged
timMillet merged 2 commits intogoogle:masterfrom Jan 4, 2021
Merged
Conversation
Explicitely tells that the referenced locations must have a `stops.location_type` value of `0` or empty. Future-proof phrasing: it references only what must be done.
timMillet
added
the
GTFS Schedule
|
Thanks, @timMillet. This looks good to me and is consistent with my understanding of the specification. |
Contributor
|
I am impatient to vote. Go Go Go! (OpenGeo) |
Contributor
Author
|
@skinkie I'd tend to think that this change is editorial only, and would not require a vote. Do you think this change is worth a vote on your side? |
Contributor
|
No, I think this just makes things more clear. |
Contributor
Author
|
Ok, thanks. I'll merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following demand in the issue #257:
This pull request clarifies the definition of the fields
stop_times.stop_id.stops.location_typevalues of0or empty.