Formatting: "Fields" and "Values" as non-header#302
Merged
sccmcca merged 1 commit intogoogle:masterfrom Jan 19, 2022
Merged
Conversation
sccmcca
added
the
GTFS Realtime
Contributor
|
👍 No need for a vote imo |
Contributor
|
👍 and I agree this is a simple formatting change and no vote is needed. |
Contributor
|
👍 |
sccmcca
pushed a commit
to MobilityData/transit
that referenced
this pull request
Feb 11, 2022
commit 2e6887e Author: scmcca <scott@mobilitydata.org> Date: Wed Feb 2 12:42:10 2022 -0500 [Formatting fix] Add newlines before lists Improved syntax for different markdown parsers commit 0033573 Author: Tristram Gräbener <tristramg@gmail.com> Date: Fri Jan 28 15:54:00 2022 +0100 Specify that the filename are case sensitive (google#300) Closes google#297 commit 23d877e Author: scott christian mccallum <scott@mobilitydata.org> Date: Tue Jan 18 19:09:46 2022 -0500 "Fields" and "Values" as non-header (google#302)
isabelle-dr
pushed a commit
to MobilityData/transit
that referenced
this pull request
Dec 19, 2023
* Squashed commit of the following: commit 2e6887e Author: scmcca <scott@mobilitydata.org> Date: Wed Feb 2 12:42:10 2022 -0500 [Formatting fix] Add newlines before lists Improved syntax for different markdown parsers commit 0033573 Author: Tristram Gräbener <tristramg@gmail.com> Date: Fri Jan 28 15:54:00 2022 +0100 Specify that the filename are case sensitive (google#300) Closes google#297 commit 23d877e Author: scott christian mccallum <scott@mobilitydata.org> Date: Tue Jan 18 19:09:46 2022 -0500 "Fields" and "Values" as non-header (google#302) * Squashed commit of the following: commit 9d5ebf1 Author: Guillaume Campagna <guillaume.campagna@gmail.com> Date: Tue Jul 26 17:09:35 2022 -0400 Add trip-to-trip transfers with in-seat option (google#303) * Add trip-to-trip transfers with in-seat option * Fix stop_id are **Conditionally Required** and formatting * Add clarification about potential conflict * Fix typo Co-authored-by: Leonard Ehrenfried <mail@leonard.io> Co-authored-by: Nicholas Paun <np@icebergsystems.ca> Co-authored-by: Leonard Ehrenfried <mail@leonard.io> commit a132709 Author: McKenzie Maidl <40008048+mckenzie-maidl-ibigroup@users.noreply.github.com> Date: Tue Jul 26 13:58:04 2022 -0700 addition of cause_detail and effect_detail to the spec (google#332) commit 8993a24 Author: Zsombor Welker <flaktack@users.noreply.github.com> Date: Mon Jul 25 14:49:40 2022 +0200 Add WheelchairAccessible documentation (google#340) * Update README.md (#63) * issue templates * update use cases section * update contact links * rename * Delete .github/ISSUE_TEMPLATE/spec_improvement.yml --------- Co-authored-by: scmcca <scott@mobilitydata.org> Co-authored-by: omar-kabbani <78552622+omar-kabbani@users.noreply.github.com> Co-authored-by: Emma Jae Blue <emma@Emma-Jae-Blue.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The titles of "Fields" and "Values" above GTFS Realtime spec tables are currently treated as headings (####). This creates a fragmented auto-generated table of contents for users navigating between elements in the spec (see screenshot from GitHub below).
To improve the navigability of the spec, this PR proposes to bold the titles of "Fields" and "Values" instead. Bolded titles are not included in auto-generated TOCs.
As this is a minor formatting fix, I'll leave 7 days of discussion. If anyone wishes a vote be held, please indicate so in the discussion and we'll follow the specification amendment process. If not, I will merge the formatting fix with no vote.
Looking forward to feedback. Thanks!