Remove depth parameter from MapHasher.HashLeaf#769
Merged
gdbelvin merged 2 commits intogoogle:masterfrom Aug 2, 2017
Merged
Conversation
gdbelvin
force-pushed
the
refactor/hasher
branch
from
dbea547 to
f519ec5
Compare
gdbelvin
changed the title
MapHasher.HashLeaf
Martin2112
reviewed
Aug 2, 2017
| return nil, status.Errorf(codes.InvalidArgument, | ||
| "len(%x): %v, want %v", l.Index, got, want) | ||
| } | ||
| // TODO(gbelvin) use LeafHash rather than computing here. #423 |
Contributor
There was a problem hiding this comment.
That todo could still be relevant?
Martin2112
approved these changes
Aug 2, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Maps, leaves are always stored at
hasher.BitLen()This PR removes the depth parameter from
HashLeaffor clarity.