Conversation
Contributor
|
Please rebase and then ping me |
added 3 commits
August 14, 2017 13:29
This will make it easier to exclude key types from the build through the use of build tags in the future. For example, PKCS#11 key support could be excluded from the build unless a build tag is used, e.g. `go build -t pkcs11`. A key benefit is that this would avoid forcing users to install dependencies for all key types - only those that they include in their build.
Required putting some of the tests in a different package to the package under test, and then using "import ." (see https://github.com/golang/go/wiki/CodeReviewComments#import-dot), so as to avoid import cycles.
- pem.NewFromPrivatePEMFile to pem.ReadPrivateKeyFile - pem.NewFromPrivatePEM to pem.UnmarshalPrivateKey - pem.NewFromPublicPEMFile to pem.ReadPublicKeyFile - pem.NewFromPublicPEM to pem.UnmarshalPublicKey - pem.NewFromPEMKeyFileProto to pem.FromProto - der.NewFromPrivateDER to der.UnmarshalPrivateKey - der.NewFromPublicDER to der.UnmarshalPublicKey - der.NewFromPrivateKeyProto to der.FromProto More consistent with other packages, e.g. crypto/x509, protobuf.
RJPercival
force-pushed
the
key_subpkgs
branch
from
91b0494 to
ad1c856
Compare
Contributor
Author
|
Rebased - PTAL. |
RJPercival
pushed a commit
to RJPercival/certificate-transparency-go
that referenced
this pull request
Aug 14, 2017
Contributor
Author
|
Travis will never be happy, as this breaks certificate-transparency-go. PR google/certificate-transparency-go#58 fixes it. |
codingllama
approved these changes
Aug 14, 2017
RJPercival
pushed a commit
to RJPercival/certificate-transparency-go
that referenced
this pull request
Aug 14, 2017
RJPercival
pushed a commit
to RJPercival/certificate-transparency-go
that referenced
this pull request
Aug 14, 2017
RJPercival
pushed a commit
to google/certificate-transparency-go
that referenced
this pull request
Aug 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future, this will make it easier to exclude support for particular key types from the build through the use of build tags. For example, PKCS#11 key support currently requires a C module that causes problems for some users - this could be excluded from the build by default, so that only those people that want it need to install the dependency.