Skip to content

Add PID qualification to TraceMeProducer/Consumers to differentiate between processes profiled together. #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −4
Open

Add PID qualification to TraceMeProducer/Consumers to differentiate between processes profiled together. #3433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tsl/profiler/lib/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ cc_library(
":traceme_encode",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/types:optional",
"@xla//xla/tsl/platform:env",
"@xla//xla/tsl/platform:types",
],
)
Expand Down
18 changes: 14 additions & 4 deletions tsl/profiler/lib/connected_traceme.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@ limitations under the License.
#ifndef TENSORFLOW_TSL_PROFILER_LIB_CONNECTED_TRACEME_H_
#define TENSORFLOW_TSL_PROFILER_LIB_CONNECTED_TRACEME_H_

#include <cstdint>
#include <optional>
#include <string>
#include <utility>

#include "absl/strings/string_view.h"
#include "absl/types/optional.h"
#include "xla/tsl/platform/env.h"
#include "xla/tsl/platform/types.h"
#include "tsl/profiler/lib/context_types.h"
#include "tsl/profiler/lib/traceme.h"
Expand Down Expand Up @@ -82,12 +84,16 @@ class TraceMeProducer : public TraceMe {
explicit TraceMeProducer(NameT&& name,
ContextType context_type = ContextType::kGeneric,
std::optional<uint64> context_id = std::nullopt,
int level = tsl::profiler::TraceMeLevel::kCritical)
int level = tsl::profiler::TraceMeLevel::kCritical,
std::optional<int32_t> pid = std::nullopt)
: TraceMe(std::forward<NameT>(name), level),
context_id_(context_id.has_value() ? context_id.value()
: TraceMe::NewActivityId()) {
AppendMetadata([&] {
return TraceMeEncode({{"_pt", context_type}, {"_p", context_id_}});
return TraceMeEncode(
{{"_pt", context_type},
{"_p", context_id_},
{"_ppid", pid.value_or(tsl::Env::Default()->GetProcessId())}});
});
}

Expand All @@ -101,10 +107,14 @@ class TraceMeConsumer : public TraceMe {
public:
template <typename NameT>
TraceMeConsumer(NameT&& name, ContextType context_type, uint64 context_id,
int level = tsl::profiler::TraceMeLevel::kCritical)
int level = tsl::profiler::TraceMeLevel::kCritical,
std::optional<uint64> pid = std::nullopt)
: TraceMe(std::forward<NameT>(name), level) {
AppendMetadata([&] {
return TraceMeEncode({{"_ct", context_type}, {"_c", context_id}});
return TraceMeEncode(
{{"_ct", context_type},
{"_c", context_id},
{"_cpid", pid.value_or(tsl::Env::Default()->GetProcessId())}});
});
}

Expand Down