Explicitly set ndkVersion to Flutter's#247
Conversation
Without this, webcrypto.dart uses AGP's default NDK version, which can be different from Flutter's preferred NDK version. Apart from causing builds to download multiple NDKs needlessly, this also causes APKs to not use 16 KB page sizes. Tested by building an APK and opening it in Android Studio's APK analyzer.
|
I was actually writing the same patch but you were first 😛 |
HamdaanAliQuatil
left a comment
There was a problem hiding this comment.
thanks for this 🚀
Use upstream master instead of a fork, since the PR has been merged. See: google/webcrypto.dart#247
|
@jonasfj If you have time, it would be great to have a new release with this fix! |
…for play console publishing. Backport of google#247 onto the 0.6.0 tag
|
@jonasfj Gentle ping, would be nice to have this available on the published package - this is blocking Google Play submissions for all Flutter apps using this library :P |
|
Can confirm that this fixed the issue for me: the |
Without this, webcrypto.dart uses AGP's default NDK version, which can be different from Flutter's preferred NDK version. Apart from causing builds to download multiple NDKs needlessly, this also causes APKs to not use 16 KB page sizes.
Tested by building an APK and opening it in Android Studio's APK analyzer.
Closes: #239