Create BddQueryEngine per-function in benchmark schedule printing.#3975
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 20, 2026
Merged
Create BddQueryEngine per-function in benchmark schedule printing.#3975copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_886442179
branch
2 times, most recently
from
2e48825 to
dfa6a76
Compare
The BddQueryEngine is associated with a single function. When printing schedule information for a PackageSchedule containing multiple functions, a new BddQueryEngine must be created and populated for each function in the package. Fixes: #3637 PiperOrigin-RevId: 886998620
copybara-service
Bot
force-pushed
the
test_886442179
branch
from
dfa6a76 to
94bbfa6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create BddQueryEngine per-function in benchmark schedule printing.
The BddQueryEngine is associated with a single function. When printing schedule information for a PackageSchedule containing multiple functions, a new BddQueryEngine must be created and populated for each function in the package.
Fixes: #3637