[codegen 1.5] Optimize state lowering by skipping self-assignments (for data)#4137
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
[codegen 1.5] Optimize state lowering by skipping self-assignments (for data)#4137copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_902838578
branch
from
7484cdb to
2238286
Compare
…or data) By skipping the data updates from `next_value` nodes that are self-assignments (where the new value is the same as the current register value), we can lean more heavily on `load_enable` and simplify our data update logic. We still need to account for these when handling our full bits, though, so we make sure to include the "no-op" write conditions in the full bit update logic. PiperOrigin-RevId: 902838578
copybara-service
Bot
force-pushed
the
test_902838578
branch
from
2238286 to
2fb6d33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[codegen 1.5] Optimize state lowering by skipping self-assignments (for data)
By skipping the data updates from
next_valuenodes that are self-assignments (where the new value is the same as the current register value), we can lean more heavily onload_enableand simplify our data update logic.We still need to account for these when handling our full bits, though, so we make sure to include the "no-op" write conditions in the full bit update logic.